Repository navigation
Enforce the peak lint tier and fix its findings - #19
Conversation
Turn every Clippy group (including pedantic) to deny, add the nursery and restriction lints that catch likely bugs (unhandled enum variants, discarded error causes, guards held across a match, hash-order dependence, hidden Arc/Rc clones, multi-op unsafe blocks) and strict rustc lints. The audit's lint policy now requires the key ones, so they cannot be dropped silently. Fixes the lints found: - Indirect-block maps and Windows disk rows use BTreeMap, so results no longer depend on hash order. - Matches list every variant; parsers drop error detail through one named CandidateEnd::malformed helper instead of |_| at each site. - Functions that could not fail no longer return Result or Option. - Generated Slint code and platform stubs carry scoped #[expect]s with reasons. The audit skips the git-ignored .claude folder, which can hold other sessions' worktrees of this repository. Also includes the move of app-level errors (updater, installer, processes) to anyhow that was already in the working tree. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 48 minutes. View limit details
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
The macOS build failed because macOS-only code was never linted on Linux or Windows. A trivial `&mut x as *mut _` cast now uses `&raw mut`, Core Foundation imports are explicit, each unsafe call has its own block and SAFETY comment (an `is_type` helper covers the CF type checks), and the rest are small lint fixes. Checked with `cargo clippy --target aarch64-apple-darwin` locally. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The fuzz crate depends on reclaim, which now uses anyhow, so `cargo check --locked` for the fuzz harnesses could not resolve it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
What
Clippy now treats every lint group as an error:
correctness,suspicious,perf,complexity,styleandpedantic. It also adds about 45 lints chosen because they catch likely bugs, plus strict compiler lints. The audit'slint_policylists the key ones, socargo testfails if one is removed fromCargo.toml.New lints include:
wildcard_enum_match_arm: a new variant can't land silently in_ =>map_err_ignore: no|_|that throws away the causesignificant_drop_in_scrutinee: a lock guard held across amatchiter_over_hash_type: output that depends on hash orderclone_on_ref_ptr:x.clone()hiding that only anArc/Rcpointer is copiedmultiple_unsafe_ops_per_block,collection_is_never_read,read_zero_byte_vectrivial_casts,unused_qualifications,elided_lifetimes_in_paths,missing_debug_implementationsSix pedantic lints that are taste rather than bugs are opted out on purpose.
indexing_slicingandarithmetic_side_effectsare still not on crate-wide: in the parsers they produce about 1,200 findings, so they will be added one module at a time.Fixes
BTreeMap, so results no longer depend on hash order.CandidateEnd,Validation,Inspection,Destinationand the XML and Markdown events list every variant.CandidateEnd::malformedhelper instead of|_|at each site. App-level errors keep their cause.ResultorOption.#[expect(lint, reason = ...)].collect()that makes sure every thread starts before any join behind the barrier intests/security.rs, which deadlocks..claude/folder, which can hold other sessions' worktrees of this repository.This branch also includes the earlier move of app-level errors (updater, installer, processes) to
anyhow, which was already in the working tree.Verified locally
cargo fmt --all -- --checkcargo test --locked: all suites pass, including the audit and the headless UI renderscargo clippy --locked --all-targets -- -D warningscargo clippy --locked --target x86_64-pc-windows-gnu --all-targets -- -D warningsmacOS was not built locally.
🤖 Generated with Claude Code
Summary by CodeRabbit